thanks for this fix!

@DamienEspitallier @JoshuaWise @mceachen isn't the if/else backwards? Reversing it fixes #1223 and the original #981

For repro I still use the minimal:

const Database = require('better-sqlite3');
const db = new Database(':memory:');

db.exec('CREATE TABLE foo (id)');

console.log(db.serialize());

Or maybe it is the wrong flag now? Turns out it actually works with 8.6.0 but for 11.1.2 it does not. I'm confused.

Edit: Can confirm that [email protected] works with [email protected] but breaks with [email protected]. But compiling it with the following changes makes it work:

however, this does not work (basically the original code):

but this works:

Someone smarter and more patient than me pls explain. Did they invert the flag on us?

Looking through https://grep.app/search?q=V8_COMPRESS_POINTERS_IN_SHARED_CAGE this is also super rarely used so maybe nobody noticed?

NODE_API_NO_EXTERNAL_BUFFERS_ALLOWED is probably the appropriate flag and we were just lucky that it previously aligned with V8_COMPRESS_POINTERS_IN_SHARED_CAGE

Can a fix for this be expected in the near future?

Is this going to be fixed?

Edit: fixed myself. #1373